HDDS-1978. Create helper script to run blockade tests.#1310
Merged
nandakumar131 merged 2 commits intoapache:trunkfrom Aug 23, 2019
Merged
HDDS-1978. Create helper script to run blockade tests.#1310nandakumar131 merged 2 commits intoapache:trunkfrom
nandakumar131 merged 2 commits intoapache:trunkfrom
Conversation
| OZONE_VERSION=$(grep "<ozone.version>" "$DIR/../../pom.xml" | sed 's/<[^>]*>//g'| sed 's/^[ \t]*//') | ||
| cd "$DIR/../../dist/target/ozone-$OZONE_VERSION/tests" || exit 1 | ||
|
|
||
| source ../compose/ozoneblockade/.env |
There was a problem hiding this comment.
shellcheck:1: note: Not following: ../compose/ozoneblockade/.env: openBinaryFile: does not exist (No such file or directory) [SC1091]
|
💔 -1 overall
This message was automatically generated. |
mukul1987
approved these changes
Aug 19, 2019
Contributor
mukul1987
left a comment
mukul1987
left a comment
There was a problem hiding this comment.
Thanks for working on this. I am +1 after fixing the checkstyle issues.
| cd "$DIR/../../dist/target/ozone-$OZONE_VERSION/tests" || exit 1 | ||
|
|
||
| source ../compose/ozoneblockade/.env | ||
| export HADOOP_RUNNER_VERSION |
Contributor
There was a problem hiding this comment.
How are these variables populated ?
Contributor
Author
There was a problem hiding this comment.
The variables are set by source ../compose/ozoneblockade/.env
The .env file will contains proper values.
| OZONE_VERSION=$(grep "<ozone.version>" "$DIR/../../pom.xml" | sed 's/<[^>]*>//g'| sed 's/^[ \t]*//') | ||
| cd "$DIR/../../dist/target/ozone-$OZONE_VERSION/tests" || exit 1 | ||
|
|
||
| source ../compose/ozoneblockade/.env |
There was a problem hiding this comment.
shellcheck:1: note: Not following: ../compose/ozoneblockade/.env: openBinaryFile: does not exist (No such file or directory) [SC1091]
|
💔 -1 overall
This message was automatically generated. |
| OZONE_VERSION=$(grep "<ozone.version>" "$DIR/../../pom.xml" | sed 's/<[^>]*>//g'| sed 's/^[ \t]*//') | ||
| cd "$DIR/../../dist/target/ozone-$OZONE_VERSION/tests" || exit 1 | ||
|
|
||
| source ${DIR}/../../dist/target/ozone-${OZONE_VERSION}/compose/ozoneblockade/.env |
There was a problem hiding this comment.
shellcheck:1: warning: Can't follow non-constant source. Use a directive to specify location. [SC1090]
shellcheck:39: note: Double quote to prevent globbing and word splitting. [SC2086]
shellcheck:8: note: Double quote to prevent globbing and word splitting. [SC2086]
|
💔 -1 overall
This message was automatically generated. |
Member
|
Looks good to me. Let me test it with starting the blockade test on the CI server. |
| OZONE_VERSION=$(grep "<ozone.version>" "$DIR/../../pom.xml" | sed 's/<[^>]*>//g'| sed 's/^[ \t]*//') | ||
| cd "$DIR/../../dist/target/ozone-$OZONE_VERSION/tests" || exit 1 | ||
|
|
||
| source ${DIR}/../../dist/target/ozone-${OZONE_VERSION}/compose/ozoneblockade/.env |
There was a problem hiding this comment.
shellcheck:1: warning: Can't follow non-constant source. Use a directive to specify location. [SC1090]
shellcheck:39: note: Double quote to prevent globbing and word splitting. [SC2086]
shellcheck:8: note: Double quote to prevent globbing and word splitting. [SC2086]
|
💔 -1 overall
This message was automatically generated. |
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
RogPodge
pushed a commit
to RogPodge/hadoop
that referenced
this pull request
Mar 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.